Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint-plugin): [prefer-null-coal] fixer w/ mixed logicals #1326

Merged
merged 2 commits into from Dec 16, 2019
Merged

fix(eslint-plugin): [prefer-null-coal] fixer w/ mixed logicals #1326

merged 2 commits into from Dec 16, 2019

Conversation

dimabory
Copy link
Contributor

fixes #1290

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @dimabory!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Dec 11, 2019 •
edited

Codecov Report

Merging #1326 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1326      +/-   ##
==========================================
+ Coverage   93.93%   93.98%   +0.04%     
==========================================
  Files         131      131              
  Lines        5840     5848       +8     
  Branches     1652     1656       +4     
==========================================
+ Hits         5486     5496      +10     
+ Misses        189      188       -1     
+ Partials      165      164       -1
Impacted Files Coverage Δ
...lint-plugin/src/rules/prefer-nullish-coalescing.ts 98.07% <100%> (+4.45%) ⬆️
packages/eslint-plugin/src/util/astUtils.ts 94.73% <100%> (+0.98%) ⬆️

bradzacher
bradzacher requested changes Dec 11, 2019
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One change.
Thanks for doing this!

packages/eslint-plugin/src/rules/prefer-nullish-coalescing.ts Outdated
@@ -117,8 +117,14 @@ export default util.createRule<Options, MessageIds>({
],
} as const)
: {
fix(fixer: TSESLint.RuleFixer): TSESLint.RuleFix {
return fixer.replaceText(barBarOperator, '??');
*fix(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Could you please keep both fixers in sync by extracting it above?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. It even helped to find and fix more issues with lack of parentheses 👍

@bradzacher bradzacher added the bug Something isn't working label Dec 11, 2019
bradzacher
bradzacher approved these changes Dec 13, 2019
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for doing this!

bradzacher
bradzacher approved these changes Dec 16, 2019
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this

@bradzacher bradzacher changed the title fix(eslint-plugin): [prefer-nullish-coalescing] eslint --fix outputs broken code fix(eslint-plugin): [prefer-null-coal] fixer w/ mixed logicals Dec 16, 2019
@bradzacher bradzacher merged commit f9a9fbf into typescript-eslint:master Dec 16, 2019
@dimabory dimabory deleted the bugfix/#1290 branch December 16, 2019 11:22
@snyk-bot snyk-bot mentioned this pull request Jan 12, 2020
Closed
This was referenced Jan 24, 2020
Closed
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@armano2 armano2 armano2 left review comments

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[prefer-nullish-coalescing] eslint --fix outputs broken code
3 participants
@dimabory @armano2 @bradzacher