Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It's not possible to have eslint run tslint fixers using @typescript-eslint/tslint/config #1340

Closed
johnwiseheart opened this issue Dec 16, 2019 · 1 comment · Fixed by #1342
Closed

It's not possible to have eslint run tslint fixers using @typescript-eslint/tslint/config #1340

johnwiseheart opened this issue Dec 16, 2019 · 1 comment · Fixed by #1342
Labels
has pr there is a PR raised to close this package: eslint-plugin-tslint Issues related to @typescript-eslint/eslint-plugin-tslint triage Waiting for maintainers to take a look

Comments

@johnwiseheart
Copy link
Contributor

I'm in the process of moving a large list of rules from tslint to eslint. The first step which makes sense to me is to setup eslint, and run tslint using the @typescript-eslint/tslint/config rule. However, it doesn't seem possible to run tslint fixers using this rule.

Is this a reasonable change that you'd accept a PR for? I feel like it should be relatively easy to just pass through the --fix flag, but maybe theres some complexity that I'm missing.
@johnwiseheart johnwiseheart added package: eslint-plugin-tslint Issues related to @typescript-eslint/eslint-plugin-tslint triage Waiting for maintainers to take a look labels Dec 16, 2019
This was referenced Dec 16, 2019
Merged
Merged
@johnwiseheart
Copy link
Contributor Author

johnwiseheart commented Dec 16, 2019 •
edited

Turned out to be easier than expected (though with a different solution to my proposed one above). Take a look at the PR: #1342

@armano2 armano2 added the has pr there is a PR raised to close this label Dec 16, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
has pr there is a PR raised to close this package: eslint-plugin-tslint Issues related to @typescript-eslint/eslint-plugin-tslint triage Waiting for maintainers to take a look
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(eslint-plugin-tslint): add fixer for config rule johnwiseheart/typescript-eslint
2 participants
@armano2 @johnwiseheart