feat(eslint-plugin-tslint): add fixer for config rule

[johnwiseheart]

Fixes: #1340

Add a fixer for the tslint config rule.

This was easier than expected - maybe I'm missing something? I'm not convinced this is tested enough, please give me any suggestions you have. I could maybe add an additional test for the prefer-const rule, which has a tslint fixer.

[typescript-eslint]

Thanks for the PR, @johnwiseheart!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[johnwiseheart]

Hmm, its unclear to me what I need to do to fix the snapshots. The original commit was red and I tried to fix it, but looks like I fixed it wrong.

[armano2]

@johnwiseheart there should not be ; in packages/eslint-plugin-tslint/tests/fixture-project/4.ts

first run failed due to integration test not unit test
https://dev.azure.com/typescript-eslint/43848853-c6f3-433c-84cc-42487a448dbf/_apis/build/builds/2583/logs/30

see tests/integration/fixtures/typescript-and-tslint-plugins-together/test.js.snap
you can regenerate it or just add changes:

-   "fixableErrorCount": 0,
+   "fixableErrorCount": 1,
...
      Object {
        "column": 20,
        "endColumn": 20,
        "endLine": 1,
+        "fix": Object {
+          "range": Array [
+            19,
+            19,
+          ],
+          "text": ";",
+        },
        "line": 1,
        "message": "Missing semicolon (tslint:semicolon)",
        "messageId": "failure",
        "nodeType": null,
        "ruleId": "@typescript-eslint/tslint/config",
        "severity": 2,
      },

---

you can execute this test localy by running (this requires you to install docker: https://docs.docker.com/compose/install/)

docker-compose -f tests/integration/docker-compose.yml up --build --abort-on-container-exit typescript-and-tslint-plugins-together

[johnwiseheart]

Hmm, it looks like this time it failed for unrelated reasons. Tried running things locally, but because of my network it doesn't work by default (I have a self-signed cert in the chain) so hopefully rerunning it will be faster than my trying to figure that out.

[armano2]

ok, restarted, for some reason it failed on downloading node 11 😕

[codecov]

Codecov Report

Merging #1342 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1342      +/-   ##
==========================================
+ Coverage   93.94%   93.94%   +<.01%     
==========================================
  Files         131      131              
  Lines        5860     5865       +5     
  Branches     1661     1662       +1     
==========================================
+ Hits         5505     5510       +5     
  Misses        188      188              
  Partials      167      167

Impacted Files	Coverage Δ
packages/eslint-plugin-tslint/src/rules/config.ts	100% <100%> (ø)	⬆️

[bradzacher]

seems like a good idea.
LGTM - thanks for this!

[johnwiseheart]

Sweet, good to merge from my end! Don't think I have permissions, so would appreciate it if you could hit the button 😄

[bradzacher]

sorry, forgot to hit it after waiting for the CI to finish