Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [quotes] ignore backticks for Enum members #1355

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #1351

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @a-tarasyuk!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Dec 19, 2019

Codecov Report

Merging #1355 into master will increase coverage by 0.03%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##           master    #1355      +/-   ##
==========================================
+ Coverage      94%   94.04%   +0.03%     
==========================================
  Files         132      132              
  Lines        5874     5876       +2     
  Branches     1663     1661       -2     
==========================================
+ Hits         5522     5526       +4     
  Misses        186      186              
+ Partials      166      164       -2
Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/quotes.ts 94.11% <88.88%> (+14.11%) ⬆️

@bradzacher bradzacher added the bug Something isn't working label Dec 19, 2019
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

One request while we're at it - could you please add the following:

  • TSMethodSignature
  • ClassProperty
  • TSAbstractClassProperty
  • TSAbstractMethodDefinition

I think that makes the complete set of property-like things that TS supports.
That way we won't have any future issues.

@a-tarasyuk
Copy link
Contributor Author

@bradzacher Sure.

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for doing this, and thanks for going the extra mile.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[@typescript-eslint/quotes] False Positive in enum
2 participants