-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-plugin): [quotes] ignore backticks for Enum members #1355
fix(eslint-plugin): [quotes] ignore backticks for Enum members #1355
Conversation
…ipt-eslint into bug/quotes-false-positive-in-enum
Thanks for the PR, @a-tarasyuk! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #1355 +/- ##
==========================================
+ Coverage 94% 94.04% +0.03%
==========================================
Files 132 132
Lines 5874 5876 +2
Branches 1663 1661 -2
==========================================
+ Hits 5522 5526 +4
Misses 186 186
+ Partials 166 164 -2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
One request while we're at it - could you please add the following:
TSMethodSignature
ClassProperty
TSAbstractClassProperty
TSAbstractMethodDefinition
I think that makes the complete set of property-like things that TS supports.
That way we won't have any future issues.
@bradzacher Sure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for doing this, and thanks for going the extra mile.
Fixes #1351