Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [pref-str-starts/ends-with] optional chain support #1357

Merged
merged 3 commits into from Dec 21, 2019

Conversation

bradzacher
Copy link
Member

See #1051

I discovered the :matches selector, which saves having to enumerate every combination, which saved a lot of effort.

Was pretty straightforward, just a lot of lines.

@bradzacher bradzacher added the enhancement New feature or request label Dec 19, 2019
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher mentioned this pull request Dec 19, 2019
25 tasks
@codecov
Copy link

codecov bot commented Dec 19, 2019

Codecov Report

Merging #1357 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1357      +/-   ##
==========================================
+ Coverage   94.05%   94.05%   +<.01%     
==========================================
  Files         133      133              
  Lines        5934     5940       +6     
  Branches     1679     1686       +7     
==========================================
+ Hits         5581     5587       +6     
  Misses        186      186              
  Partials      167      167
Impacted Files Coverage Δ
...ages/eslint-plugin/src/rules/no-require-imports.ts 100% <ø> (ø) ⬆️
...ackages/eslint-plugin/src/rules/prefer-includes.ts 100% <ø> (ø) ⬆️
...plugin/src/rules/prefer-string-starts-ends-with.ts 100% <100%> (ø) ⬆️

# Conflicts:
#	packages/eslint-plugin/src/rules/prefer-string-starts-ends-with.ts
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant