Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): use AST_NODE_TYPES instead of strings in rules #1366

Merged
merged 2 commits into from Dec 21, 2019
Merged

fix(eslint-plugin): use AST_NODE_TYPES instead of strings in rules #1366

merged 2 commits into from Dec 21, 2019

Conversation

armano2
Copy link
Member

@armano2 armano2 commented Dec 20, 2019

  • remove 2 invalid selectors GetAccessor and SetAccessor from rule prefer-readonly

- remove 2 invalid selectors GetAccessor and SetAccessor from rule prefer-readonly
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Dec 20, 2019

Codecov Report

Merging #1366 into master will increase coverage by <.01%.
The diff coverage is 96%.

@@            Coverage Diff             @@
##           master    #1366      +/-   ##
==========================================
+ Coverage   94.04%   94.05%   +<.01%     
==========================================
  Files         133      133              
  Lines        5929     5934       +5     
  Branches     1677     1679       +2     
==========================================
+ Hits         5576     5581       +5     
  Misses        186      186              
  Partials      167      167
Impacted Files Coverage Δ
...ges/eslint-plugin/src/rules/no-inferrable-types.ts 93.1% <ø> (ø) ⬆️
...ackages/eslint-plugin/src/rules/prefer-readonly.ts 99.1% <ø> (ø) ⬆️
...kages/eslint-plugin/src/rules/no-empty-function.ts 88.46% <0%> (ø) ⬆️
...nt-plugin/src/rules/indent-new-do-not-use/index.ts 98.4% <100%> (ø) ⬆️
...ackages/eslint-plugin/src/rules/prefer-includes.ts 100% <100%> (ø) ⬆️
...plugin/src/rules/prefer-string-starts-ends-with.ts 100% <100%> (ø) ⬆️
...nt-plugin/src/rules/space-before-function-paren.ts 100% <100%> (ø) ⬆️
...ackages/eslint-plugin/src/rules/member-ordering.ts 92.3% <100%> (ø) ⬆️
...slint-plugin/src/rules/no-unnecessary-qualifier.ts 96.15% <100%> (+0.07%) ⬆️
...nt-plugin/src/rules/consistent-type-definitions.ts 90.32% <100%> (+0.32%) ⬆️
... and 1 more

@armano2 armano2 added the package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin label Dec 20, 2019
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for cleaning this up. I was actually thinking the other day we should implement an internal lint rule to enforce this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants