Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-estree): correct type of key for base nodes #1367

Merged
merged 1 commit into from Dec 21, 2019
Merged

fix(typescript-estree): correct type of key for base nodes #1367

merged 1 commit into from Dec 21, 2019

Conversation

armano2
Copy link
Member

@armano2 armano2 commented Dec 20, 2019

This is follow up PR of #1349 that fixes recently introduced invalid key type for base properties

export type PropertyName = PropertyNameComputed | PropertyNameNonComputed;

in some places type was defined as PropertyNameComputed | PropertyNameComputed

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@armano2 armano2 added bug Something isn't working package: typescript-estree Issues related to @typescript-eslint/typescript-estree labels Dec 20, 2019
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks for catching this

@bradzacher bradzacher changed the title fix(ts-estree): correct type of key for base nodes fix(typescript-estree): correct type of key for base nodes Dec 21, 2019
@bradzacher bradzacher merged commit 099225a into typescript-eslint:master Dec 21, 2019
@armano2 armano2 deleted the fix-ts-estree-types branch December 21, 2019 03:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working package: typescript-estree Issues related to @typescript-eslint/typescript-estree
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants