Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): add isTypeAssertion utility function #1369

Merged
merged 1 commit into from Dec 21, 2019

Conversation

bradzacher
Copy link
Member

While working on a new rule, I noticed that there were a few places that we didn't check for both angle bracket and as assertions.
This introduces a utility function which does that, and uses it everywhere.

While working on a new rule, I noticed that there were a few places that we didn't check for both angle bracket and as assertions.
This introduces a utility function which does that, and uses it everywhere.
@bradzacher bradzacher added the bug Something isn't working label Dec 21, 2019
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Dec 21, 2019

Codecov Report

Merging #1369 into master will decrease coverage by 0.03%.
The diff coverage is 88.46%.

@@            Coverage Diff             @@
##           master    #1369      +/-   ##
==========================================
- Coverage   94.05%   94.02%   -0.04%     
==========================================
  Files         133      133              
  Lines        5940     5941       +1     
  Branches     1686     1685       -1     
==========================================
- Hits         5587     5586       -1     
- Misses        186      187       +1     
- Partials      167      168       +1
Impacted Files Coverage Δ
...-plugin/src/rules/explicit-function-return-type.ts 100% <100%> (ø) ⬆️
packages/eslint-plugin/src/util/astUtils.ts 87.5% <60%> (-7.24%) ⬇️
...ackages/eslint-plugin/src/rules/no-extra-parens.ts 96.22% <94.44%> (-0.14%) ⬇️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant