Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): add no-implied-eval #1375

Merged

Conversation

a-tarasyuk
Copy link
Contributor

No description provided.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @a-tarasyuk!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher added the enhancement: new base rule extension New base rule extension required to handle a TS specific case label Dec 24, 2019
Comment on lines +291 to +294
setTimeout('x = 1', 0);
setInterval('x = 1', 0);
setImmediate('x = 1');
execScript('x = 1');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question:
Do we want to have handling for these cases? Or are we okay with just handling the normal call?
These cases are getting into a bit of the world of "someone's trying really hard to do something weird", so it's probably okay to ignore them.

setTimeout.call(<something>, 'x = 1', 0);
setInterval.call(<something>, 'x = 1', 0);
setImmediate.call(<something>, 'x = 1');
execScript.call(<something>, 'x = 1');
setTimeout.apply(<something>, ['x = 1', 0]);
setInterval.apply(<something>, ['x = 1', 0]);
setImmediate.apply(<something>, ['x = 1']);
execScript.apply(<something>, ['x = 1']);

@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Dec 24, 2019
@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Dec 31, 2019
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one last change, then this is ready to go.

Thanks heaps for working on this!

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement: new base rule extension New base rule extension required to handle a TS specific case
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants