Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): type assertion in rule no-extra-parens #1376

Merged
merged 2 commits into from Dec 24, 2019
Merged

fix(eslint-plugin): type assertion in rule no-extra-parens #1376

merged 2 commits into from Dec 24, 2019

Conversation

armano2
Copy link
Member

@armano2 armano2 commented Dec 24, 2019

This PR adds test cases for type assertion in rule no-extra-parens and fixes issue with incorrectly reported parens in binary expressions for type assertions

((a as any) | 0) - 1

test cases covers changes added in #1369

closes #742
fixes #807

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@armano2 armano2 changed the title test(eslint-plugin): no-extra-parens test cases for type assertion fix(eslint-plugin): type assertion in rule no-extra-parens Dec 24, 2019
@codecov
Copy link

codecov bot commented Dec 24, 2019

Codecov Report

Merging #1376 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1376      +/-   ##
==========================================
+ Coverage   94.04%   94.04%   +<.01%     
==========================================
  Files         139      139              
  Lines        5975     5979       +4     
  Branches     1691     1692       +1     
==========================================
+ Hits         5619     5623       +4     
  Misses        192      192              
  Partials      164      164
Impacted Files Coverage Δ
...ackages/eslint-plugin/src/rules/no-extra-parens.ts 96.49% <100%> (+0.26%) ⬆️

@bradzacher bradzacher added the bug Something isn't working label Dec 24, 2019
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
2 participants