feat(typescript-estree): add strict type mapping to parserServices.esTreeNodeToTSNodeMap

[armano2]

I'm unsure if we actually want this change and if place where type is defined is good one.

i was also thinking about name: ParserServicesConvertibleTypes

---

rules that will have to be updated to use more strict types instead of Node:

• no-unnecessary-condition
• no-unnecessary-qualifier
• no-unused-vars-experimental
• prefer-readonly
• prefer-regexp-exec
• prefer-string-starts-ends-with
• promise-function-async
• restrict-plus-operands
• restrict-template-expressions
• strict-boolean-expressions

---

@bradzacher what do you think about this?

---

for example in prefer-regexp-exec function isStringType is used to check type but as argument it accepts TSESTree.Node and it should TSESTree.LeftHandSideExpression

[bradzacher]

there are a lot of places that I just dropped in TSESTree.Node when it doesn't actually matter what the node type is (no explicit checks on props, etc).

Instead of using an excludes, I think it would be a good idea to strictly type the get method on ParserWeakMap - we know the mapping that exists because we own the conversion logic, so we should be able to do something similar to RuleListener.

Also for Program:exit, could you just add that to the RuleListener list? It's a pretty common pattern.

For the getter on ParserWeakMap, and for RuleListener, we should probably just create a build script to generate the files.

WDYT?

[armano2]

@bradzacher type mapping is added, i'm unsure if we should expose it to plugins

[bradzacher]

I was actually thinking we should do something like this, but I was too lazy to go through the parser logic and pull out the mapping. So thanks!

I think this is a good idea, and I like the idea of removing the manual conversion as I wouldn't be surprised if we got it wrong around the place.

Could you also run the no-unnecessary-type-arguments rule to fix up any manual annotations that are now unnecessary?

[bradzacher]

LGTM - one question then I'm happy for this to merge.

[bradzacher]

There wasn't a bug before, just relaxed types; so switching this to a feat, it's an enhancement and strictification of the types we already provided.