fix(typescript-estree): correct persisted parse for windows #1406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
armano2
changed the title
armano2
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1406 +/- ##
=======================================
Coverage 94.43% 94.43%
=======================================
Files 140 140
Lines 6034 6034
Branches 1712 1712
=======================================
Hits 5698 5698
Misses 186 186
Partials 150 150
|
armano2
changed the title
bradzacher
approved these changes
Jan 6, 2020
This was referenced Jan 15, 2020
This was referenced Feb 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows and Linux/Mac uses different path separator.
currently some of tests do not pass on windows machines because of that
this is used by persisted parse and may be related to #1394