Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-estree): parsing of deeply nested new files in new folder #1412

Merged
merged 6 commits into from Jan 8, 2020
Merged

Conversation

armano2
Copy link
Member

@armano2 armano2 commented Jan 8, 2020

Context:

Currently ** is resolved only as directory, it means that for ./**/* paths /src/test.ts, /test.ts is going to work but /src/test/test.ts will not.

This is edge case and happens when you setup includes with **.

Config example:

// tsconfig.extend.json
{
  "include": ["src"],
}
// tsconfig.json
{
  "extends": "./tsconfig.extend.json",
  "include": ["./**/*"],
}

fixes #1394

@typescript-eslint

This comment has been minimized.

@armano2 armano2 changed the title add test file with nested directory test(typescript-estree): add test file with nested directory Jan 8, 2020
@armano2 armano2 changed the base branch from 1394-tests to master January 8, 2020 00:54
@armano2 armano2 changed the title test(typescript-estree): add test file with nested directory fix(typescript-estree): mark directories as changed when used with asterisks Jan 8, 2020
@codecov
Copy link

codecov bot commented Jan 8, 2020

Codecov Report

Merging #1412 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1412      +/-   ##
==========================================
+ Coverage   94.58%   94.58%   +<.01%     
==========================================
  Files         140      140              
  Lines        6057     6058       +1     
  Branches     1723     1723              
==========================================
+ Hits         5729     5730       +1     
  Misses        181      181              
  Partials      147      147
Impacted Files Coverage Δ
...pt-estree/src/create-program/createWatchProgram.ts 92.35% <100%> (+0.04%) ⬆️

@armano2 armano2 changed the title fix(typescript-estree): mark directories as changed when used with asterisks fix(typescript-estree): mark directories as changed when include has ** Jan 8, 2020
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one suggestion, just to better integrate it

packages/typescript-estree/tests/lib/persistentParse.ts Outdated Show resolved Hide resolved
@armano2 armano2 changed the title fix(typescript-estree): mark directories as changed when include has ** fix(typescript-estree): parsing of deeply nested new files in new folder Jan 8, 2020
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, great work figuring out this hard to repro bug.
thanks so much!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IDE Parsing error when using overlapping globs
2 participants