Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experimental-utils): expose getParserServices from utils #1448

Merged
merged 3 commits into from Jan 14, 2020
Merged

feat(experimental-utils): expose getParserServices from utils #1448

merged 3 commits into from Jan 14, 2020

Conversation

armano2
Copy link
Member

@armano2 armano2 commented Jan 13, 2020

This change got extracted from #716 as non breaking feature

@armano2 armano2 added the package: utils Issues related to the @typescript-eslint/utils package label Jan 13, 2020
@typescript-eslint

This comment has been minimized.

bradzacher
bradzacher previously approved these changes Jan 14, 2020
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for pulling this out

Note - there are build failures atm

@armano2
Copy link
Member Author

armano2 commented Jan 14, 2020

dev experimental-utils are not picked up in docker :(

@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #1448 into master will increase coverage by 1.55%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1448      +/-   ##
==========================================
+ Coverage   94.02%   95.57%   +1.55%     
==========================================
  Files         143      143              
  Lines        6456     6458       +2     
  Branches     1822     1823       +1     
==========================================
+ Hits         6070     6172     +102     
+ Misses        210      110     -100     
  Partials      176      176
Impacted Files Coverage Δ
...nt-plugin/src/rules/indent-new-do-not-use/index.ts 98.4% <100%> (ø) ⬆️
...kages/eslint-plugin/src/rules/naming-convention.ts 87.88% <100%> (+0.03%) ⬆️
...xperimental-utils/src/eslint-utils/applyDefault.ts 100% <0%> (+16.66%) ⬆️
...ges/experimental-utils/src/ts-eslint/RuleTester.ts 28.57% <0%> (+28.57%) ⬆️
...mental-utils/src/eslint-utils/getParserServices.ts 33.33% <0%> (+33.33%) ⬆️
...experimental-utils/src/eslint-utils/RuleCreator.ts 66.66% <0%> (+66.66%) ⬆️
...l-utils/src/eslint-utils/batchedSingleLineTests.ts 92.3% <0%> (+92.3%) ⬆️
packages/experimental-utils/src/ts-eslint/index.ts 100% <0%> (+100%) ⬆️
...perimental-utils/src/ts-eslint-scope/Definition.ts 100% <0%> (+100%) ⬆️
...xperimental-utils/src/ts-eslint-scope/Reference.ts 100% <0%> (+100%) ⬆️
... and 11 more

@bradzacher bradzacher merged commit 982c8bc into typescript-eslint:master Jan 14, 2020
@armano2 armano2 deleted the getParserServices-part1 branch January 14, 2020 17:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: utils Issues related to the @typescript-eslint/utils package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants