Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [no-extra-non-null-assertion] flag optional chain after a non-null assertion #1460

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #1397

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @a-tarasyuk!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ezpz. LGTM, thanks for adding this!

@bradzacher bradzacher changed the title feat(eslint-plugin): flag optional chain after a non-null assertion feat(eslint-plugin): [no-extra-!-assert] flag ?. after !-assert Jan 16, 2020
@bradzacher bradzacher merged commit 58c7c25 into typescript-eslint:master Jan 16, 2020
@bradzacher bradzacher changed the title feat(eslint-plugin): [no-extra-!-assert] flag ?. after !-assert feat(eslint-plugin): flag optional chain after a non-null assertion Jan 16, 2020
@bradzacher bradzacher changed the title feat(eslint-plugin): flag optional chain after a non-null assertion feat(eslint-plugin): [no-extra-non-null-assertion] flag optional chain after a non-null assertion Jan 16, 2020
@armano2 armano2 added enhancement: plugin rule option New rule option for an existing eslint-plugin rule package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin labels Jan 19, 2020
mightyiam added a commit to mightyiam/eslint-config-love that referenced this pull request Feb 4, 2020
BREAKING CHANGE: new rule @typescript-eslint/no-non-null-asserted-optional-chain
typescript-eslint/typescript-eslint#1469

BREAKING CHANGE: [no-extra-non-null-assertion] flag optional chain after a non-null assertion
typescript-eslint/typescript-eslint#1460

Closes #218.
mightyiam added a commit to mightyiam/eslint-config-love that referenced this pull request Feb 11, 2020
BREAKING CHANGE: new rule @typescript-eslint/no-non-null-asserted-optional-chain
typescript-eslint/typescript-eslint#1469

BREAKING CHANGE: [no-extra-non-null-assertion] flag optional chain after a non-null assertion
typescript-eslint/typescript-eslint#1460

Closes #218.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule suggestion: flag optional chain after a non-null assertion
3 participants