Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [no-extra-non-null-assert] add fixer #1468

Merged
merged 4 commits into from Jan 30, 2020

Conversation

bradzacher
Copy link
Member

@bradzacher bradzacher commented Jan 18, 2020

Simple enough.
Also adds support for optional call expressions

@bradzacher bradzacher added the enhancement: plugin rule option New rule option for an existing eslint-plugin rule label Jan 18, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Jan 30, 2020

Codecov Report

Merging #1468 into master will decrease coverage by 0.19%.
The diff coverage is 93.52%.

@@            Coverage Diff            @@
##           master    #1468     +/-   ##
=========================================
- Coverage   95.55%   95.36%   -0.2%     
=========================================
  Files         144      151      +7     
  Lines        6570     6683    +113     
  Branches     1878     1890     +12     
=========================================
+ Hits         6278     6373     +95     
- Misses        111      118      +7     
- Partials      181      192     +11
Impacted Files Coverage Δ
...nt-plugin/src/rules/indent-new-do-not-use/index.ts 98.4% <ø> (ø) ⬆️
...rimental-utils/src/ts-eslint-scope/ScopeManager.ts 100% <ø> (ø) ⬆️
...xperimental-utils/src/ts-eslint-scope/Reference.ts 100% <ø> (ø) ⬆️
...nt-plugin/src/rules/no-unused-vars-experimental.ts 91.39% <ø> (ø) ⬆️
...ges/eslint-plugin/src/rules/no-inferrable-types.ts 93.1% <ø> (ø) ⬆️
packages/eslint-plugin/src/rules/indent.ts 92.68% <ø> (ø) ⬆️
...ges/experimental-utils/src/ts-eslint/SourceCode.ts 100% <ø> (ø) ⬆️
...experimental-utils/src/ts-eslint-scope/Variable.ts 100% <ø> (ø) ⬆️
packages/eslint-plugin/src/rules/no-type-alias.ts 100% <ø> (ø) ⬆️
...es/experimental-utils/src/ts-eslint-scope/Scope.ts 100% <ø> (ø) ⬆️
... and 29 more

@bradzacher bradzacher merged commit 54201ab into master Jan 30, 2020
@bradzacher bradzacher deleted the no-extra-non-null-fixer branch January 30, 2020 01:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant