Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): add no-non-null-asserted-optional-chain #1469

Merged
merged 2 commits into from Jan 18, 2020

Conversation

bradzacher
Copy link
Member

Fixes #1398

@bradzacher bradzacher added the enhancement: new plugin rule New rule request for eslint-plugin label Jan 18, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Jan 18, 2020

Codecov Report

Merging #1469 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1469      +/-   ##
==========================================
+ Coverage   95.55%   95.55%   +<.01%     
==========================================
  Files         144      145       +1     
  Lines        6569     6576       +7     
  Branches     1878     1878              
==========================================
+ Hits         6277     6284       +7     
  Misses        111      111              
  Partials      181      181
Impacted Files Coverage Δ
...n/src/rules/no-non-null-asserted-optional-chain.ts 100% <100%> (ø)
packages/eslint-plugin/src/rules/index.ts 100% <100%> (ø) ⬆️

@bradzacher bradzacher merged commit 498aa24 into master Jan 18, 2020
@bradzacher bradzacher deleted the no-non-null-asserted-optional-chain branch January 20, 2020 23:54
mightyiam added a commit to mightyiam/eslint-config-love that referenced this pull request Feb 4, 2020
BREAKING CHANGE: new rule @typescript-eslint/no-non-null-asserted-optional-chain
typescript-eslint/typescript-eslint#1469

BREAKING CHANGE: [no-extra-non-null-assertion] flag optional chain after a non-null assertion
typescript-eslint/typescript-eslint#1460

Closes #218.
mightyiam added a commit to mightyiam/eslint-config-love that referenced this pull request Feb 11, 2020
BREAKING CHANGE: new rule @typescript-eslint/no-non-null-asserted-optional-chain
typescript-eslint/typescript-eslint#1469

BREAKING CHANGE: [no-extra-non-null-assertion] flag optional chain after a non-null assertion
typescript-eslint/typescript-eslint#1460

Closes #218.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement: new plugin rule New rule request for eslint-plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule suggestion: flag non-null assertion applied to an optional chain
2 participants