Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [naming-convention] fix filter option #1482

Merged
merged 1 commit into from Jan 24, 2020

Conversation

bradzacher
Copy link
Member

Fixes #1478

I had the logic just slightly wrong

@bradzacher bradzacher added the bug Something isn't working label Jan 21, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Jan 21, 2020

Codecov Report

Merging #1482 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1482      +/-   ##
==========================================
+ Coverage   95.55%   95.56%   +0.01%     
==========================================
  Files         144      146       +2     
  Lines        6569     6591      +22     
  Branches     1878     1881       +3     
==========================================
+ Hits         6277     6299      +22     
  Misses        111      111              
  Partials      181      181
Impacted Files Coverage Δ
...kages/eslint-plugin/src/rules/naming-convention.ts 88.45% <100%> (ø) ⬆️
packages/eslint-plugin/src/rules/index.ts 100% <0%> (ø) ⬆️
packages/eslint-plugin/src/rules/ban-ts-ignore.ts 100% <0%> (ø) ⬆️
packages/eslint-plugin/src/rules/ban-ts-comment.ts 100% <0%> (ø)
...n/src/rules/no-non-null-asserted-optional-chain.ts 100% <0%> (ø)

@bradzacher bradzacher merged commit 718cd88 into master Jan 24, 2020
@bradzacher bradzacher deleted the fix-naming-convention-filter branch January 24, 2020 17:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[naming-convention] Specificity of filter seems low (attempting to create exception)
2 participants