feat(eslint-plugin): additional annotation spacing rules for variables, parameters, properties, return types

[chkt]

This PR provides additional annotation spacing rules as discussed in #1489. The additional rules for variable declarations, function parameters, properties and return types are non-breaking and conform to the preexisting configuration conventions of the rule.

Fixes #1489

[typescript-eslint]

Thanks for the PR, @chkt!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[bradzacher]

logic itself looks sound, just some suggested changes around your guards.
Thanks for working on this.

[codecov]

Codecov Report

Merging #1496 into master will decrease coverage by 0.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1496      +/-   ##
==========================================
- Coverage   95.57%   95.30%   -0.27%     
==========================================
  Files         143      143              
  Lines        6689     6736      +47     
  Branches     1916     1938      +22     
==========================================
+ Hits         6393     6420      +27     
- Misses        106      110       +4     
- Partials      190      206      +16     

[bradzacher]

LGTM!
Thanks for your work on this

[alumni]

This would disallow:

export type Constructor<T = {}> = new (...args: any[]) => T;

and force:

export type Constructor<T = {}> = new (...args: any[])=> T;

The space before the arrow is removed.
I know styling is subjective, but the first one looks better :)

[alumni]

Also, it's not what the docs say it's the default: https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/type-annotation-spacing.md

[bradzacher]

Please use the issue search.
This has been fixed in master #1663