Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): fix property access on undefined error #1507

Merged
merged 1 commit into from Jan 24, 2020
Merged

fix(eslint-plugin): fix property access on undefined error #1507

merged 1 commit into from Jan 24, 2020

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Jan 24, 2020

馃尞

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @G-Rath!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


馃檹 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Jan 24, 2020

Codecov Report

Merging #1507 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1507   +/-   ##
======================================
  Coverage    95.6%   95.6%           
======================================
  Files         148     148           
  Lines        6664    6664           
  Branches     1909    1909           
======================================
  Hits         6371    6371           
  Misses        111     111           
  Partials      182     182
Impacted Files Coverage 螖
...-plugin/src/rules/no-unnecessary-type-arguments.ts 97.82% <100%> (酶) 猬嗭笍

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typechecking is only good if your types are right - and the typescript API types are sometimes garbage.
Thanks for fixing this!

@bradzacher bradzacher added the bug Something isn't working label Jan 24, 2020
@bradzacher bradzacher merged commit d89e8e8 into typescript-eslint:master Jan 24, 2020
@G-Rath G-Rath deleted the fix-cannot-read-property-of-undefined branch January 24, 2020 08:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants