feat(eslint-plugin): add new no-base-to-string rule

[JoshuaKGoldberg]

Fixes #258.

[typescript-eslint]

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[bradzacher]

mostly lgtm.
a few suggestions.
thanks for working on this

[JoshuaKGoldberg]

Btw, I re-read the conversation in #203, and it looks like this would be one of the rules where the no- prefix would be preferable. Added 👍

[bradzacher]

noice

thanks for this, LGTM

[codecov]

Codecov Report

Merging #1522 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1522      +/-   ##
==========================================
+ Coverage   95.53%   95.56%   +0.02%     
==========================================
  Files         142      143       +1     
  Lines        6630     6670      +40     
  Branches     1900     1910      +10     
==========================================
+ Hits         6334     6374      +40     
  Misses        106      106              
  Partials      190      190              

Impacted Files	Coverage Δ
...kages/eslint-plugin/src/rules/no-base-to-string.ts	100.00% <0.00%> (ø)

[felixfbecker]

I noticed a false positive on URLSearchParams toString(). Probably should have an actual addition to dom.d.ts since it's overridden?

[HolgerJeromin]

I have no idea why I get an error for this boolean:
error @typescript-eslint/no-base-to-string : 'window.navigator.cookieEnabled will evaluate to '[Object object]' when stringified.

[bradzacher]

#1655

Please use the issue search.