Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(experimental-utils): widen type of settings property #1527

Merged
merged 2 commits into from Jan 26, 2020
Merged

fix(experimental-utils): widen type of settings property #1527

merged 2 commits into from Jan 26, 2020

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Jan 25, 2020

Currently attempting to access context.settings['<property>'] nets me

TS7053: Element implicitly has an 'any' type because expression of type '"local/configs"' can't be used to index type '{}'.
  Property 'local/configs' does not exist on type '{}'.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @G-Rath!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

Co-Authored-By: Armano <armano2@users.noreply.github.com>
@bradzacher bradzacher added the bug Something isn't working label Jan 26, 2020
@bradzacher
Copy link
Member

thanks!

@bradzacher bradzacher merged commit b515e47 into typescript-eslint:master Jan 26, 2020
@G-Rath G-Rath deleted the widen-settings-type branch January 26, 2020 20:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants