Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-estree): fix regression introduced in #1525 #1543

Merged
merged 1 commit into from Jan 29, 2020
Merged

fix(typescript-estree): fix regression introduced in #1525 #1543

merged 1 commit into from Jan 29, 2020

Conversation

armano2
Copy link
Member

@armano2 armano2 commented Jan 29, 2020

This PR fixes regression for prettier introduced in #1525

unblocks prettier/prettier#7463

@armano2 armano2 self-assigned this Jan 29, 2020
@typescript-eslint

This comment has been minimized.

@armano2 armano2 added the package: typescript-estree Issues related to @typescript-eslint/typescript-estree label Jan 29, 2020
@codecov
Copy link

codecov bot commented Jan 29, 2020

Codecov Report

Merging #1543 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1543      +/-   ##
==========================================
- Coverage   95.36%   95.36%   -0.01%     
==========================================
  Files         151      151              
  Lines        6683     6682       -1     
  Branches     1891     1890       -1     
==========================================
- Hits         6373     6372       -1     
  Misses        118      118              
  Partials      192      192
Impacted Files Coverage Δ
packages/typescript-estree/src/convert.ts 99.43% <100%> (-0.01%) ⬇️

@bradzacher bradzacher merged commit bec4572 into typescript-eslint:master Jan 29, 2020
@armano2 armano2 deleted the fix-regression branch January 29, 2020 20:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: typescript-estree Issues related to @typescript-eslint/typescript-estree
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants