feat(eslint-plugin): [explicit-member-accessibility] autofix no-public

[pablobirukov]

Partially addresses #503.

Autofixes problems reported by "no-public" config option

[typescript-eslint]

Thanks for the PR, @pablobirukov!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[codecov]

Codecov Report

Merging #1548 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1548      +/-   ##
==========================================
+ Coverage   95.42%   95.43%   +<.01%     
==========================================
  Files         140      140              
  Lines        6400     6414      +14     
  Branches     1832     1836       +4     
==========================================
+ Hits         6107     6121      +14     
  Misses        108      108              
  Partials      185      185

Impacted Files	Coverage Δ
...-plugin/src/rules/explicit-member-accessibility.ts	97.1% <100%> (+0.73%)	⬆️

[bradzacher]

Thanks for working on this.
A few comments.

[bradzacher]

almost there. two final comments on the tests.

• could you please add output tests for all unwantedPublicAccessibility error messages in the tests? Might as well ensure we're covering all the bases (I'm sure it's all working right, but never hurts to over-cover)
• could you please add a three test cases for the following, just to ensure that if someone changes the rule in the future, we don't lose functionality:

  • public              constructor() {}
    

  • public /* */              constructor() {}
    

  • public              /* */ constructor() {}
    

Thanks for working on this.

[pablobirukov]

@bradzacher will you please take a look? I have addressed your comments

[bradzacher]

thanks for working on this!
LGTM