Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [unbound-method] blacklist a few unbound natives #1562

Merged
merged 1 commit into from Feb 3, 2020

Conversation

bradzacher
Copy link
Member

@bradzacher bradzacher commented Feb 3, 2020

#1526 Added a whitelist of member expressions which are bound by default .
But of the ~100 methods in the list, ~15 aren't actually bound (for whatever reason).
This just adds a blacklist alongside the whitelist so we don't false-negative.

I highly doubt anyone will ever actually do const x = Promise.all in their code, but we might as well be correct.

#1526 Added a whitelist of member expressions which are bound by default .
But of the ~100 methods in the list, ~15 aren't actually bound (for whatever reason).
This just adds a blacklist alongside the whitelist so we don't false-negative.
@bradzacher bradzacher added the bug Something isn't working label Feb 3, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Feb 3, 2020

Codecov Report

Merging #1562 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1562      +/-   ##
==========================================
+ Coverage   95.56%   95.56%   +<.01%     
==========================================
  Files         142      142              
  Lines        6516     6519       +3     
  Branches     1855     1855              
==========================================
+ Hits         6227     6230       +3     
  Misses        105      105              
  Partials      184      184
Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/unbound-method.ts 96.66% <100%> (+0.17%) ⬆️

@bradzacher bradzacher merged commit 4670aab into master Feb 3, 2020
@bradzacher bradzacher deleted the unbound-method-unbound-globals branch February 3, 2020 20:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants