Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [no-unnecessary-condition] remove checkArrayPredicates and always check it #1579

Merged
merged 3 commits into from May 11, 2020

Conversation

Retsam
Copy link
Contributor

@Retsam Retsam commented Feb 7, 2020

BREAKING CHANGE:

This removes the checkArrayPredicates option, and enables it as the default behavior of the rule. I think this makes sense as default, non-configurable behavior: I don't really see a case where you wouldn't want the unnecessary condition logic to apply to array predicates which function as conditionals.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @Retsam!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher added breaking change This change will require a new major version to be released enhancement New feature or request labels Feb 7, 2020
@bradzacher bradzacher added this to the 3.0.0 milestone Feb 7, 2020
@codecov
Copy link

codecov bot commented Feb 7, 2020

Codecov Report

Merging #1579 into v3 will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##               v3    #1579   +/-   ##
=======================================
  Coverage   93.63%   93.63%           
=======================================
  Files         169      169           
  Lines        7667     7667           
  Branches     2190     2190           
=======================================
  Hits         7179     7179           
  Misses        229      229           
  Partials      259      259           
Flag Coverage Δ
#unittest 93.63% <100.00%> (ø)
Impacted Files Coverage Δ
...slint-plugin/src/rules/no-unnecessary-condition.ts 96.96% <100.00%> (ø)

@bradzacher bradzacher changed the base branch from master to v3 May 10, 2020 00:23
# Conflicts:
#	packages/eslint-plugin/src/rules/no-unnecessary-condition.ts
#	packages/eslint-plugin/tests/rules/no-unnecessary-condition.test.ts
@bradzacher bradzacher changed the title feat(eslint-plugin): [no-unnecessary-condition] check array predicates by default feat(eslint-plugin): [no-unnecessary-condition] remove checkArrayPredicates and always check it May 11, 2020
@bradzacher bradzacher merged commit 51c3389 into typescript-eslint:v3 May 11, 2020
bradzacher pushed a commit that referenced this pull request May 11, 2020
bradzacher pushed a commit that referenced this pull request May 14, 2020
bradzacher pushed a commit that referenced this pull request May 17, 2020
bradzacher pushed a commit that referenced this pull request May 21, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking change This change will require a new major version to be released enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants