Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-floating-promises] handle finally callback #1620

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #1603

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @a-tarasyuk!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Feb 19, 2020

Codecov Report

Merging #1620 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1620      +/-   ##
==========================================
+ Coverage   95.54%   95.55%   +<.01%     
==========================================
  Files         142      142              
  Lines        6583     6585       +2     
  Branches     1883     1884       +1     
==========================================
+ Hits         6290     6292       +2     
  Misses        106      106              
  Partials      187      187
Impacted Files Coverage Δ
...es/eslint-plugin/src/rules/no-floating-promises.ts 100% <100%> (ø) ⬆️

@bradzacher bradzacher added the bug Something isn't working label Feb 19, 2020
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[no-floating-promises] Finally callback reports as false positive for unhanded promises
2 participants