Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): add rule no-unsafe-member-access #1643

Merged
merged 1 commit into from Mar 3, 2020

Conversation

bradzacher
Copy link
Member

@bradzacher bradzacher commented Feb 26, 2020

See #791

I think it's better to introduce these as a number of separate rules.
It makes it easier for people to opt in to the rules, and keeps each implementation small and focused.
This also makes it easier and faster to build and release, as we can build and release smaller rules instead of releasing one monolithic rule.


This rule simply checks all member expressions, and makes sure that you're not chaining a member expression off of an any type.
It inspects the inner-most member expression of a chain to provide the most correct error location.

@bradzacher bradzacher added the enhancement: new plugin rule New rule request for eslint-plugin label Feb 26, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Feb 26, 2020

Codecov Report

Merging #1643 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1643      +/-   ##
==========================================
+ Coverage   95.35%   95.37%   +0.02%     
==========================================
  Files         145      146       +1     
  Lines        6804     6836      +32     
  Branches     1957     1964       +7     
==========================================
+ Hits         6488     6520      +32     
  Misses        111      111              
  Partials      205      205              
Impacted Files Coverage Δ
...eslint-plugin/src/rules/no-unsafe-member-access.ts 100.00% <0.00%> (ø)

@bradzacher bradzacher linked an issue Feb 26, 2020 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement: new plugin rule New rule request for eslint-plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New set of rules: no-unsafe-*
1 participant