Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): add rule no-unsafe-call #1647

Merged
merged 1 commit into from Mar 3, 2020
Merged

Conversation

bradzacher
Copy link
Member

@bradzacher bradzacher commented Feb 27, 2020

See #791

I think it's better to introduce these as a number of separate rules.
It makes it easier for people to opt in to the rules, and keeps each implementation small and focused.
This also makes it easier and faster to build and release, as we can build and release smaller rules instead of releasing one monolithic rule.

Based off of #1644


This rule simply checks all call/new expressions, and makes sure that you're not calling/constructing an any type.

@bradzacher bradzacher added enhancement: new plugin rule New rule request for eslint-plugin blocked by another PR PRs which are ready to go but waiting on another PR labels Feb 27, 2020
@bradzacher bradzacher linked an issue Feb 27, 2020 that may be closed by this pull request
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher changed the base branch from master to no-unsafe-return February 28, 2020 07:22
@bradzacher bradzacher force-pushed the no-unsafe-call branch 4 times, most recently from ecbf587 to 4f10ca3 Compare March 3, 2020 07:20
@bradzacher bradzacher force-pushed the no-unsafe-call branch 2 times, most recently from 202dca3 to 8fbc865 Compare March 3, 2020 07:56
@bradzacher bradzacher force-pushed the no-unsafe-return branch 2 times, most recently from 0402a87 to e8d922a Compare March 3, 2020 08:52
@bradzacher bradzacher changed the base branch from no-unsafe-return to master March 3, 2020 09:10
@bradzacher bradzacher removed the blocked by another PR PRs which are ready to go but waiting on another PR label Mar 3, 2020
@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

Merging #1647 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1647   +/-   ##
=======================================
  Coverage   95.36%   95.37%           
=======================================
  Files         147      148    +1     
  Lines        6904     6916   +12     
  Branches     1985     1988    +3     
=======================================
+ Hits         6584     6596   +12     
  Misses        112      112           
  Partials      208      208           
Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/no-unsafe-call.ts 100.00% <0.00%> (ø)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement: new plugin rule New rule request for eslint-plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New set of rules: no-unsafe-*
1 participant