Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-implied-eval] correct logic for ts3.8 #1652

Merged
merged 1 commit into from Feb 29, 2020

Conversation

bradzacher
Copy link
Member

@bradzacher bradzacher commented Feb 28, 2020

Fixes #1642

Tested this against 3.7.5 and 3.8.2 and it works in both.

The changes in the tests were just whitespace changes and changing { code: `...` } to be inline.

@bradzacher bradzacher added the bug Something isn't working label Feb 28, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Feb 28, 2020

Codecov Report

Merging #1652 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1652      +/-   ##
==========================================
+ Coverage   95.53%   95.54%   +0.01%     
==========================================
  Files         142      142              
  Lines        6623     6627       +4     
  Branches     1896     1897       +1     
==========================================
+ Hits         6327     6332       +5     
  Misses        106      106              
+ Partials      190      189       -1
Impacted Files Coverage Δ
...ackages/eslint-plugin/src/rules/no-implied-eval.ts 97.82% <100%> (+1.9%) ⬆️
packages/eslint-plugin/src/rules/ban-types.ts 100% <0%> (ø) ⬆️
...ages/eslint-plugin/src/rules/default-param-last.ts 100% <0%> (ø) ⬆️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive with no-implied-eval
1 participant