Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [prefer-readonly-parameter-types] handle recursive types #1672

Merged
merged 1 commit into from Mar 4, 2020

Conversation

bradzacher
Copy link
Member

@bradzacher bradzacher commented Mar 4, 2020

Fixes #1665

Also did a small refactor to use an enum instead of boolean | null, because it's cleaner.

@bradzacher bradzacher added the bug Something isn't working label Mar 4, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Mar 4, 2020

Codecov Report

Merging #1672 into master will decrease coverage by <.01%.
The diff coverage is 97.14%.

@@            Coverage Diff             @@
##           master    #1672      +/-   ##
==========================================
- Coverage   95.35%   95.35%   -0.01%     
==========================================
  Files         148      148              
  Lines        6918     6931      +13     
  Branches     1989     1992       +3     
==========================================
+ Hits         6597     6609      +12     
  Misses        112      112              
- Partials      209      210       +1
Impacted Files Coverage Δ
packages/eslint-plugin/src/util/isTypeReadonly.ts 97.01% <97.14%> (-1.14%) ⬇️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[prefer-readonly-parameter-types] Emits an error on a recursive type
1 participant