Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [no-unsafe-member-access] report any typed computed prop access #1683

Merged
merged 2 commits into from Mar 9, 2020

Conversation

bradzacher
Copy link
Member

Context: #791 (comment)

Simple enough.
Accessing using a property via a computed key which is typed as any is unsafe.
noImplicitAny actually catches this when accessing properties on object types, but it does not do the same check on arrays.

@bradzacher bradzacher added the enhancement: plugin rule option New rule option for an existing eslint-plugin rule label Mar 5, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher added enhancement New feature or request and removed enhancement: plugin rule option New rule option for an existing eslint-plugin rule labels Mar 5, 2020
@codecov
Copy link

codecov bot commented Mar 5, 2020

Codecov Report

Merging #1683 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1683      +/-   ##
==========================================
+ Coverage   95.17%   95.17%   +<.01%     
==========================================
  Files         148      148              
  Lines        6938     6947       +9     
  Branches     1999     2002       +3     
==========================================
+ Hits         6603     6612       +9     
  Misses        124      124              
  Partials      211      211
Impacted Files Coverage Δ
...eslint-plugin/src/rules/no-unsafe-member-access.ts 100% <100%> (ø) ⬆️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant