Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): add extension rule lines-between-class-members #1684

Merged
merged 6 commits into from May 12, 2020
Merged

feat(eslint-plugin): add extension rule lines-between-class-members #1684

merged 6 commits into from May 12, 2020

Conversation

yeonjuan
Copy link
Contributor

@yeonjuan yeonjuan commented Mar 5, 2020

Fixes #1610

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Mar 5, 2020

Codecov Report

Merging #1684 into master will decrease coverage by 0.00%.
The diff coverage is 92.30%.

@@            Coverage Diff             @@
##           master    #1684      +/-   ##
==========================================
- Coverage   93.93%   93.93%   -0.01%     
==========================================
  Files         171      172       +1     
  Lines        7816     7829      +13     
  Branches     2243     2245       +2     
==========================================
+ Hits         7342     7354      +12     
  Misses        217      217              
- Partials      257      258       +1     
Flag Coverage Δ
#unittest 93.93% <92.30%> (-0.01%) ⬇️
Impacted Files Coverage Δ
...nt-plugin/src/rules/lines-between-class-members.ts 92.30% <92.30%> (ø)

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

Haven't reviewed the code yet, but just some quick feedback on the docs.

Example of how we like to do extension rule docs now a days - instead of copy-pasting the ESLint docs, just list the changes we're adding to the rule, and link out to the ESLint docs.
That way we don't have to worry as much about getting out of date.

https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/func-call-spacing.md

I.e. in this case, you can just list the new option and how it works, and that covers it.

@bradzacher bradzacher added awaiting response Issues waiting for a reply from the OP or another party enhancement: new base rule extension New base rule extension required to handle a TS specific case labels Mar 5, 2020
@yeonjuan
Copy link
Contributor Author

yeonjuan commented Mar 6, 2020

@bradzacher
Thank you for the quick response and feedback. :). I changed it.

# Conflicts:
#	packages/eslint-plugin/README.md
#	packages/eslint-plugin/src/configs/all.json
#	packages/eslint-plugin/typings/eslint-rules.d.ts
@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label May 6, 2020
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! code mostly LGTM - a few linting errors to fix before this can be merged.

@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label May 11, 2020
@yeonjuan yeonjuan requested a review from bradzacher May 12, 2020 04:47
@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label May 12, 2020
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks!

@bradzacher bradzacher changed the title feat(eslint-plugin): add lines-between-class-members feat(eslint-plugin): add extension rule lines-between-class-members May 12, 2020
@bradzacher bradzacher merged commit 08f93e6 into typescript-eslint:master May 12, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement: new base rule extension New base rule extension required to handle a TS specific case
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[lines-between-class-members] does not make sense with overloading
2 participants