Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript-estree): support 3.8 import/export type #1697

Merged
merged 3 commits into from Mar 9, 2020

Conversation

bradzacher
Copy link
Member

Based on #1696

Following babel's lead here with their existing AST that's used for flow babel/babel#11171

@bradzacher bradzacher added the enhancement New feature or request label Mar 7, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher added the blocked by another PR PRs which are ready to go but waiting on another PR label Mar 7, 2020
@bradzacher bradzacher requested a review from armano2 March 7, 2020 04:33
@bradzacher bradzacher changed the base branch from bump-ts-3-8 to master March 9, 2020 01:04
@bradzacher bradzacher removed the blocked by another PR PRs which are ready to go but waiting on another PR label Mar 9, 2020
@codecov
Copy link

codecov bot commented Mar 9, 2020

Codecov Report

Merging #1697 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1697      +/-   ##
==========================================
+ Coverage   95.17%   95.18%   +0.01%     
==========================================
  Files         148      148              
  Lines        6938     6953      +15     
  Branches     1997     2005       +8     
==========================================
+ Hits         6603     6618      +15     
  Misses        124      124              
  Partials      211      211              
Impacted Files Coverage Δ
packages/typescript-estree/src/convert.ts 98.87% <100.00%> (+<0.01%) ⬆️
...eslint-plugin/src/rules/no-unsafe-member-access.ts 100.00% <0.00%> (ø)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant