New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin): [ban-ts-comment] support ts-expect-error
#1706
feat(eslint-plugin): [ban-ts-comment] support ts-expect-error
#1706
Conversation
Thanks for the PR, @G-Rath! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
I'm not sure about the default. In most cases, Of course, the real issue is that TypeScript doesn't allow you to ignore/expect specific errors (by code). The rule states:
This is surely true for |
Yeah i would agree. |
Codecov Report
@@ Coverage Diff @@
## master #1706 +/- ##
==========================================
- Coverage 94.49% 94.39% -0.11%
==========================================
Files 162 163 +1
Lines 7471 7580 +109
Branches 2139 2182 +43
==========================================
+ Hits 7060 7155 +95
- Misses 178 182 +4
- Partials 233 243 +10
|
ts-expect-error
comment directivets-expect-error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
change ts-expect-error
to be banned by default, and then this is good to merge
This one should be safe to merge without TS3.9 being released - it'll just meant the docs are a bit confusing for a few months, which we should solve by putting a note on them about "feature not being released".
I've made the default
true
, as I thinkts-expect-error
is safer, and it's possible to restrict a thing too much :)closes #1709