Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): add rule prefer-reduce-type-parameter #1707

Merged
merged 12 commits into from Apr 13, 2020
Merged

feat(eslint-plugin): add rule prefer-reduce-type-parameter #1707

merged 12 commits into from Apr 13, 2020

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Mar 8, 2020

Guess who figured out how to use TS internals 馃帀馃帀馃帀
(or at least, rework them from require-array-sort-compare 馃槀)

closes #1604

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @G-Rath!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


馃檹 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher added the enhancement: new plugin rule New rule request for eslint-plugin label Mar 8, 2020
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your work!
not a full review, just a few comments from a quick eyeball of the code

@codecov
Copy link

codecov bot commented Mar 20, 2020

Codecov Report

Merging #1707 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1707      +/-   ##
==========================================
+ Coverage   94.48%   94.50%   +0.01%     
==========================================
  Files         162      163       +1     
  Lines        7487     7512      +25     
  Branches     2146     2153       +7     
==========================================
+ Hits         7074     7099      +25     
  Misses        178      178              
  Partials      235      235              
Flag Coverage 螖
#unittest 94.50% <100.00%> (+0.01%) 猬嗭笍
Impacted Files Coverage 螖
...t-plugin/src/rules/prefer-reduce-type-parameter.ts 100.00% <100.00%> (酶)
...s/experimental-utils/src/eslint-utils/deepMerge.ts 89.47% <100.00%> (酶)

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, test coverage is ace

Fix the lints and we good to go

@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Apr 12, 2020
@G-Rath G-Rath requested a review from bradzacher April 12, 2020 23:32
@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Apr 13, 2020
@bradzacher bradzacher changed the title feat(eslint-plugin): create prefer-reduce-type-parameter rule feat(eslint-plugin): add rule prefer-reduce-type-parameter Apr 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement: new plugin rule New rule request for eslint-plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New rule: use type parameter for .reduce instead of a cast
2 participants