Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ban-ts-comment] // @ts-expect-error should be recognized #1709

Closed
JoshuaKGoldberg opened this issue Mar 9, 2020 · 1 comment · Fixed by #1706
Closed

[ban-ts-comment] // @ts-expect-error should be recognized #1709

JoshuaKGoldberg opened this issue Mar 9, 2020 · 1 comment · Fixed by #1706
Labels
enhancement New feature or request has pr there is a PR raised to close this package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Mar 9, 2020 •
edited

Repro

{
  "rules": {
    "@typescript-eslint/ban-ts-comment": "error"
  }
}

In TypeScript@next (3.9):

// @ts-expect-error
let invalid: number = "nope";

Expected Result

As of microsoft/TypeScript#36014, // @ts-expect-error should be recognized and able to be banned by @typescript-eslint/ban-ts-comment.

Actual Result

It isn't yet.

Versions

package version
@typescript-eslint/eslint-plugin 2.22.1-alpha.6
@typescript-eslint/parser 2.22.0
TypeScript 3.8.3
ESLint 6.8.0
node v12.4.0
npm 6.9.0
@JoshuaKGoldberg JoshuaKGoldberg added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for maintainers to take a look labels Mar 9, 2020
@bradzacher
Copy link
Member

see: #1706

@bradzacher bradzacher added enhancement New feature or request has pr there is a PR raised to close this and removed triage Waiting for maintainers to take a look labels Mar 9, 2020
@G-Rath G-Rath mentioned this issue Mar 9, 2020
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request has pr there is a PR raised to close this package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(eslint-plugin): [ban-ts-comment] support ts-expect-error
2 participants
@JoshuaKGoldberg @bradzacher