fix(eslint-plugin): use isTypeArrayTypeOrUnionOfArrayTypes util for checking if type is array

[G-Rath]

Based on discussion here, which was broken out into #1721.

I've not yet checked the rest of the rules for possible refactoring.

[typescript-eslint]

Thanks for the PR, @G-Rath!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[codecov]

Codecov Report

Merging #1728 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1728      +/-   ##
==========================================
- Coverage   94.48%   94.48%   -0.01%     
==========================================
  Files         162      162              
  Lines        7494     7484      -10     
  Branches     2151     2146       -5     
==========================================
- Hits         7081     7071      -10     
  Misses        178      178              
  Partials      235      235              

Flag	Coverage Δ
#unittest	94.48% <100.00%> (-0.01%)	⬇️

Impacted Files	Coverage Δ
...ackages/eslint-plugin/src/rules/no-for-in-array.ts	100.00% <100.00%> (ø)
packages/eslint-plugin/src/rules/no-unsafe-call.ts	100.00% <100.00%> (ø)
...ckages/eslint-plugin/src/rules/no-unsafe-return.ts	95.00% <100.00%> (ø)
...int-plugin/src/rules/require-array-sort-compare.ts	100.00% <100.00%> (ø)
.../eslint-plugin/src/rules/restrict-plus-operands.ts	100.00% <100.00%> (ø)
...-plugin/src/rules/restrict-template-expressions.ts	100.00% <100.00%> (ø)
packages/eslint-plugin/src/util/types.ts	81.59% <100.00%> (+0.58%)	⬆️

[bradzacher]

lgtm.

I should probably build a lint rule to suggest against:

• getTypeAtLocation in favour of getConstrainedTypeAtLocation, and
• isArrayType in favour of isTypeArrayTypeOrUnionOfArrayTypes

[bradzacher]

Linting again 😅