Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[restrict-template-expressions] change option name allowNullable to allowNullish #1810

Closed
phaux opened this issue Mar 27, 2020 · 0 comments · Fixed by #2006
Closed

[restrict-template-expressions] change option name allowNullable to allowNullish #1810

phaux opened this issue Mar 27, 2020 · 0 comments · Fixed by #2006
Labels
breaking change This change will require a new major version to be released enhancement New feature or request package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Milestone
3.0.0

Comments

@phaux
Copy link
Contributor

phaux commented Mar 27, 2020

It would make more sense if the option which allows undefined and null would be called "allowNullish" because "nullish" usually refers to a value which is either null or undefined. "nullable type" usually refers to a type which can be T | undefined | null.

I made this rule and I didn't care about that distinction back then, but I think it is important for consistency. I think it's a good time to change this for 3.0
@phaux phaux added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for maintainers to take a look labels Mar 27, 2020
@bradzacher bradzacher added breaking change This change will require a new major version to be released enhancement New feature or request and removed triage Waiting for maintainers to take a look labels Mar 27, 2020
@bradzacher bradzacher added this to the 3.0.0 milestone Mar 27, 2020
@bradzacher bradzacher mentioned this issue May 11, 2020
Merged
@bradzacher bradzacher linked a pull request May 11, 2020 that will close this issue
feat(eslint-plugin): [restrict-template-expressions] rename allowNullable to allowNullish #2006
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
breaking change This change will require a new major version to be released enhancement New feature or request package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
3.0.0
2 participants
@phaux @bradzacher