Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-unsafe-return] error with <TS3.7 #1815

Merged
merged 1 commit into from Mar 28, 2020

Conversation

bradzacher
Copy link
Member

@bradzacher bradzacher commented Mar 28, 2020

Fixes #1807

tested by installing TS@3.6.2 and running the tests.
They passed.

@bradzacher bradzacher added the bug Something isn't working label Mar 28, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Mar 28, 2020

Codecov Report

Merging #1815 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1815      +/-   ##
==========================================
- Coverage   94.99%   94.96%   -0.03%     
==========================================
  Files         159      159              
  Lines        7112     7114       +2     
  Branches     2033     2035       +2     
==========================================
  Hits         6756     6756              
- Misses        154      155       +1     
- Partials      202      203       +1
Flag Coverage Δ
#unittest 94.96% <0%> (-0.03%) ⬇️
Impacted Files Coverage Δ
packages/eslint-plugin/src/util/types.ts 80.26% <0%> (-1.08%) ⬇️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[no-unsafe-return] TypeError: checker.getTypeArguments is not a function
1 participant