Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-throw-literal] fix crash caused by getBaseTypes #1830

Merged
merged 1 commit into from Apr 1, 2020

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #1775

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @a-tarasyuk!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

bradzacher
bradzacher previously approved these changes Apr 1, 2020
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thanks

@bradzacher bradzacher added the bug Something isn't working label Apr 1, 2020
@bradzacher
Copy link
Member

note @a-tarasyuk - test failures

@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #1830 into master will not change coverage by %.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1830   +/-   ##
=======================================
  Coverage   94.64%   94.64%           
=======================================
  Files         160      160           
  Lines        7263     7263           
  Branches     2081     2082    +1     
=======================================
  Hits         6874     6874           
  Misses        167      167           
  Partials      222      222           
Flag Coverage Δ
#unittest 94.64% <100.00%> (ø)
Impacted Files Coverage Δ
...ckages/eslint-plugin/src/rules/no-throw-literal.ts 95.74% <100.00%> (ø)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[@typescript-eslint/no-throw-literal] throws an error in some cases
2 participants