Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experimental-utils): update eslint types to match v6.8 #1846

Merged
merged 1 commit into from Apr 5, 2020

Conversation

bradzacher
Copy link
Member

went through the history on the definitely typed types to update our copies.
I need to pay a bit more attention to ESLint releases so that I don't miss this stuff.

@bradzacher bradzacher added the enhancement New feature or request label Apr 4, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Apr 4, 2020

Codecov Report

Merging #1846 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1846   +/-   ##
=======================================
  Coverage   94.71%   94.71%           
=======================================
  Files         161      161           
  Lines        7338     7338           
  Branches     2101     2101           
=======================================
  Hits         6950     6950           
  Misses        165      165           
  Partials      223      223           
Flag Coverage Δ
#unittest 94.71% <ø> (ø)
Impacted Files Coverage Δ
...rimental-utils/src/ts-eslint-scope/ScopeManager.ts 100.00% <ø> (ø)
.../experimental-utils/src/ts-eslint-scope/analyze.ts 100.00% <ø> (ø)
...ages/experimental-utils/src/ts-eslint/CLIEngine.ts 0.00% <ø> (ø)
...ackages/experimental-utils/src/ts-eslint/Linter.ts 100.00% <ø> (ø)
...ges/experimental-utils/src/ts-eslint/RuleTester.ts 28.57% <ø> (ø)

@bradzacher bradzacher changed the title feat(experimental-utils): update eslint types to match eslint 6.8 feat(experimental-utils): update eslint types to match v6.8 Apr 5, 2020
@bradzacher bradzacher merged commit 16ce74d into master Apr 5, 2020
@bradzacher bradzacher deleted the eslint-types-update-6-8 branch April 5, 2020 17:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant