Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [member-ordering] add decorators support #1870

Merged
merged 7 commits into from Apr 27, 2020
Merged

feat(eslint-plugin): [member-ordering] add decorators support #1870

merged 7 commits into from Apr 27, 2020

Conversation

miluoshi
Copy link
Contributor

@miluoshi miluoshi commented Apr 8, 2020

Fixes #1863

This PR adds support for grouping decorated fields and methods separately, optionally specifying their accessibility. See updated docs for details.

I'm happy to answer any questions or discuss concerns.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @miluoshi!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Apr 8, 2020

Codecov Report

Merging #1870 into master will decrease coverage by 0.00%.
The diff coverage is 94.28%.

@@            Coverage Diff             @@
##           master    #1870      +/-   ##
==========================================
- Coverage   94.36%   94.36%   -0.01%     
==========================================
  Files         168      168              
  Lines        7651     7664      +13     
  Branches     2199     2204       +5     
==========================================
+ Hits         7220     7232      +12     
  Misses        183      183              
- Partials      248      249       +1     
Flag Coverage Δ
#unittest 94.36% <94.28%> (-0.01%) ⬇️
Impacted Files Coverage Δ
...ackages/eslint-plugin/src/rules/member-ordering.ts 98.46% <94.28%> (-0.69%) ⬇️

@bradzacher bradzacher added the enhancement: plugin rule option New rule option for an existing eslint-plugin rule label Apr 8, 2020
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thanks for this!
please fix up the merge conflict and we can merge this

@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Apr 26, 2020
@miluoshi
Copy link
Contributor Author

lgtm - thanks for this!
please fix up the merge conflict and we can merge this

Done. Thanks for the review!

@bradzacher
Copy link
Member

@miluoshi - FYI your merge introduced formatting errors

@miluoshi
Copy link
Contributor Author

miluoshi commented Apr 27, 2020

@bradzacher Yes, I've noticed it and fixed it with the last commit, but I'm not sure why the Code style check still fails. I ran the format-check script locally and it passed.

@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Apr 27, 2020
@bradzacher bradzacher merged commit f7ec192 into typescript-eslint:master Apr 27, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[member-ordering] add support for grouping decorated class members
2 participants