Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-empty-interface] use suggestion fixer for ambient contexts #1880

Merged
merged 6 commits into from Apr 12, 2020
Merged

fix(eslint-plugin): [no-empty-interface] use suggestion fixer for ambient contexts #1880

merged 6 commits into from Apr 12, 2020

Conversation

greyscaled
Copy link
Contributor

Summary

Uses a suggested fix (instead of auto-fix) when an empty interface is found inside an ambient declaration.

Resolves: #1875

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @vapurrmaid!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher added the bug Something isn't working label Apr 11, 2020
@codecov
Copy link

codecov bot commented Apr 11, 2020

Codecov Report

Merging #1880 into master will decrease coverage by 0.00%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##           master    #1880      +/-   ##
==========================================
- Coverage   94.49%   94.49%   -0.01%     
==========================================
  Files         162      162              
  Lines        7471     7481      +10     
  Branches     2139     2143       +4     
==========================================
+ Hits         7060     7069       +9     
  Misses        178      178              
- Partials      233      234       +1     
Flag Coverage Δ
#unittest 94.49% <92.85%> (-0.01%) ⬇️
Impacted Files Coverage Δ
...ages/eslint-plugin/src/rules/no-empty-interface.ts 96.15% <92.85%> (-3.85%) ⬇️

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments, otherwise LGTM - thanks for this!

packages/eslint-plugin/src/rules/no-empty-interface.ts Outdated Show resolved Hide resolved
packages/eslint-plugin/src/rules/no-empty-interface.ts Outdated Show resolved Hide resolved
@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Apr 12, 2020
G r e y and others added 4 commits April 11, 2020 22:10
Co-Authored-By: Brad Zacher <brad.zacher@gmail.com>
This should fix the -0.01 coverage report
@greyscaled
Copy link
Contributor Author

Thanks for pointing me in the direction with the example snippet, greatly appreciated 👍 🎉

@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Apr 12, 2020
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brilliant - thanks for this!

@bradzacher bradzacher changed the title fix(eslint-plugin): suggest within TSModuleDecl fix(eslint-plugin): [no-empty-interface] use suggestion fixer for ambient contexts Apr 12, 2020
@bradzacher bradzacher merged commit 62b2278 into typescript-eslint:master Apr 12, 2020
@greyscaled greyscaled deleted the empty-interface-decl-merging branch April 12, 2020 05:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[no-empty-interface] Disable in declaration merging contexts
3 participants