New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-plugin): [no-empty-interface] use suggestion fixer for ambient contexts #1880
fix(eslint-plugin): [no-empty-interface] use suggestion fixer for ambient contexts #1880
Conversation
Thanks for the PR, @vapurrmaid! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #1880 +/- ##
==========================================
- Coverage 94.49% 94.49% -0.01%
==========================================
Files 162 162
Lines 7471 7481 +10
Branches 2139 2143 +4
==========================================
+ Hits 7060 7069 +9
Misses 178 178
- Partials 233 234 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few comments, otherwise LGTM - thanks for this!
Co-Authored-By: Brad Zacher <brad.zacher@gmail.com>
This should fix the -0.01 coverage report
Thanks for pointing me in the direction with the example snippet, greatly appreciated 👍 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
brilliant - thanks for this!
Summary
Uses a suggested fix (instead of auto-fix) when an empty interface is found inside an ambient declaration.
Resolves: #1875