Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-base-to-string] soft remove ignoreTaggedTemplateExpressions option #1916

Conversation

LinusU
Copy link
Contributor

@LinusU LinusU commented Apr 18, 2020

ref: #1914

This "soft" removes the ignoreTaggedTemplateExpressions option, treating it as always true.

In the next breaking change, 3.0, we can remove this option altogether ☺️

Let me know if you want to approach this in another way, this is my first PR here, happy to learn!

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @LinusU!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@LinusU LinusU force-pushed the deprecate-ignoreTaggedTemplateExpressions branch from 569a3f9 to f927afd Compare April 18, 2020 09:57
@codecov
Copy link

codecov bot commented Apr 18, 2020

Codecov Report

Merging #1916 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1916   +/-   ##
=======================================
  Coverage   94.37%   94.37%           
=======================================
  Files         164      164           
  Lines        7572     7572           
  Branches     2175     2175           
=======================================
  Hits         7146     7146           
  Misses        183      183           
  Partials      243      243           
Flag Coverage Δ
#unittest 94.37% <ø> (ø)
Impacted Files Coverage Δ
...kages/eslint-plugin/src/rules/no-base-to-string.ts 100.00% <ø> (ø)

@bradzacher bradzacher added the bug Something isn't working label Apr 18, 2020
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@bradzacher bradzacher changed the title fix(eslint-plugin): [no-base-to-string] soft remove "ignoreTaggedTemplateExpressions" option fix(eslint-plugin): [no-base-to-string] soft remove ignoreTaggedTemplateExpressions option Apr 20, 2020
@bradzacher bradzacher merged commit 369978e into typescript-eslint:master Apr 20, 2020
@LinusU LinusU deleted the deprecate-ignoreTaggedTemplateExpressions branch April 20, 2020 06:44
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants