feat(eslint-plugin): [restrict-template-expressions] improve error message #1926
Conversation
|
Thanks for the PR, @ulrichb! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
…(add invalid type) * Also refactor (`isInnerUnionOrIntersectionConformingTo()`) and improve its name. * Also add `TWithNoConstraint` test case.
Codecov Report
@@ Coverage Diff @@
## master #1926 +/- ##
==========================================
- Coverage 93.93% 93.93% -0.01%
==========================================
Files 172 172
Lines 7829 7828 -1
Branches 2245 2245
==========================================
- Hits 7354 7353 -1
Misses 217 217
Partials 258 258
|
ulrichb
force-pushed
the
feat/ImproveRestrictTemplateMessage
branch
from
bd90c8b
to
e49b80f
Compare
bradzacher
changed the title
|
@bradzacher: Thanks for your review and merging! |
This makes it easier to understand the error especially when type inference is involved.
Also refactor (
isInnerUnionOrIntersectionConformingTo()) and improve its name by making it more specific (the previous "UnderlyingExpressionType" wasn't really clear).