Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experimental-utils): expose our RuleTester extension #1948

Merged
merged 1 commit into from Apr 29, 2020

Conversation

bradzacher
Copy link
Member

There are a few things we've built in (like automatically adding a filename) that others might find value in.
Plus I want to use it in the internal plugin.

@bradzacher bradzacher added the enhancement New feature or request label Apr 28, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Apr 28, 2020

Codecov Report

Merging #1948 into master will decrease coverage by 0.42%.
The diff coverage is 12.50%.

@@            Coverage Diff             @@
##           master    #1948      +/-   ##
==========================================
- Coverage   94.35%   93.92%   -0.43%     
==========================================
  Files         168      169       +1     
  Lines        7664     7704      +40     
  Branches     2204     2215      +11     
==========================================
+ Hits         7231     7236       +5     
- Misses        183      218      +35     
  Partials      250      250              
Flag Coverage Δ
#unittest 93.92% <12.50%> (-0.43%) ⬇️
Impacted Files Coverage Δ
.../experimental-utils/src/eslint-utils/RuleTester.ts 10.25% <10.25%> (ø)
...kages/experimental-utils/src/eslint-utils/index.ts 100.00% <100.00%> (ø)

There are a few things we've built in (like automatically adding a filename) that others might find value in.
Plus I want to use it in the internal plugin.
@bradzacher bradzacher merged commit 2dd1638 into master Apr 29, 2020
@bradzacher bradzacher deleted the expose-rule-tester branch April 30, 2020 07:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant