feat(eslint-plugin-internal): add rule no-poorly-typed-ts-props #1949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradzacher
added
the
repo maintenance
|
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #1949 +/- ##
==========================================
- Coverage 93.92% 93.90% -0.02%
==========================================
Files 169 170 +1
Lines 7704 7731 +27
Branches 2215 2221 +6
==========================================
+ Hits 7236 7260 +24
- Misses 218 219 +1
- Partials 250 252 +2
|
bradzacher
force-pushed
the
no-poorly-typed-ts-props
branch
from
a77b26f
to
26ee35b
Compare
bradzacher
added
the
blocked by another PR
There are a few things we've built in (like automatically adding a filename) that others might find value in. Plus I want to use it in the internal plugin.
Simple lint rule to ban usage of properties that introduce bugs. microsoft/TypeScript#24706
bradzacher
force-pushed
the
no-poorly-typed-ts-props
branch
from
26ee35b
to
78f0942
Compare
bradzacher
removed
the
blocked by another PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple lint rule to ban usage of properties that introduce bugs.
(See: microsoft/TypeScript#24706)
Will prevent future issues like #1945
BASED ON #1948