feat(eslint-plugin): [require-array-sort-compare] add ignoreStringArrays option

[sosukesuzuki]

Fixes #1963

[typescript-eslint]

Thanks for the PR, @sosukesuzuki!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[codecov]

Codecov Report

Merging #1972 into master will decrease coverage by 0.01%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master    #1972      +/-   ##
==========================================
- Coverage   93.45%   93.44%   -0.02%     
==========================================
  Files         171      171              
  Lines        7813     7821       +8     
  Branches     2227     2229       +2     
==========================================
+ Hits         7302     7308       +6     
- Misses        244      245       +1     
- Partials      267      268       +1     

Flag	Coverage Δ
#unittest	93.44% <77.77%> (-0.02%)	⬇️

Impacted Files	Coverage Δ
...int-plugin/src/rules/require-array-sort-compare.ts	88.23% <77.77%> (-11.77%)	⬇️

[bradzacher]

thanks for your work!
a few comments.

[bradzacher]

this only works for array expressions that have sort directly called on them: ['a'].sort()

A better solution would be to check the type of the node instead, and extract the type of the generic parameters.

All array types (string[] and Array<string>) are treated as Array<string> in code.
All tuple types ([a, b, c]) are treated as Tuple<T1, T2, ...> (a special variadic type).

const type = checker.getTypeAtLocation(
  service.esTreeNodeToTSNodeMap.get(node),
);
if (checker.isArrayType(type) || checker.isTupleType(type)) {
  const typeArgs = checker.getTypeArguments(type);
  return checker.getTypeArguments(type).every(
    arg => util.getTypeName(checker, arg) === 'string',
  );
}
return false;

[sosukesuzuki]

Thank you for your review. I fixed all reviewed points!

[bradzacher]

LGTM - thanks for this!

[finnigantime]

@sosukesuzuki Thank you for adding this!