fix(eslint-plugin): [no-base-to-string] support boolean in unions #1979
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1974.
Added an extra check to the
no-base-to-string.ts
rule to handle the case when a union includes special-case types (specifically, booleans since those tend to be the most common offenders). Whenever we know we have a union, instead of just checking if there is some useful subtype, we also check if all subtypes are useful. If all subtypes are useful, there should be no warning.Note: This should almost certainly be removed once the boolean toString no longer requires special consideration.